RFR: 1797: Add support for /backport pull request command [v3]

Erik Helin ehelin at openjdk.org
Thu Feb 2 11:41:02 UTC 2023

On Thu, 2 Feb 2023 00:14:38 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> This patch introduces support for the /backport command in pull requests. (ErikJ and ErikH proposed the idea and came up with this implementation.)
>> Usage of /backport in pull request:
>> Syntax: `/backport <repo> [<branch>] ` ` /backport disable <repo> [<branch>]` (default branch is master)
>> 1. If the `/backport` command is used in an **open** pull request, it adds a label `Backport=repo:branch` to the PR. If the PR is later integrated, the PR bot scans for backport labels and begins the backporting process. To cancel the backport, the user can use `/backport disable repo master` to remove the label before the PR is integrated.
>> 2.  If the `/backport` command is used in an **integrated** PR, it creates the backport branch and comments on the PR. This process is similar to using the /backport command in commits. (This feature was implemented in [SKARA-1495](https://bugs.openjdk.org/browse/SKARA-1495) by guoxiong li, but the usage was not documented on the[ wiki page](https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands), so seems like few people use this command)
>> 3.  If the `/backport` command is used in a **closed** (not integrated) PR, the user will receive an error message stating that the command cannot be used in a closed but not integrated PR.
> Zhao Song has updated the pull request incrementally with two additional commits since the last revision:
>  - fix test
>  - fix issues

bots/pr/src/main/java/org/openjdk/skara/bots/pr/BackportCommand.java line 132:

> 130: 
> 131:     private String generateBackportLabel(String targetRepo, String targetBranchName) {
> 132:         return "Backport=" + targetRepo + ":" + targetBranchName;

I think all of the labels we use for OpenJDK use only lowercase, so I would suggest using `backport=<repo>:<branch>` for the labels.


PR: https://git.openjdk.org/skara/pull/1466

More information about the skara-dev mailing list