RFR: 1797: Add support for /backport pull request command [v3]

Zhao Song zsong at openjdk.org
Thu Feb 2 16:51:59 UTC 2023


On Thu, 2 Feb 2023 11:38:40 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - fix test
>>  - fix issues
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/BackportCommand.java line 132:
> 
>> 130: 
>> 131:     private String generateBackportLabel(String targetRepo, String targetBranchName) {
>> 132:         return "Backport=" + targetRepo + ":" + targetBranchName;
> 
> I think all of the labels we use for OpenJDK use only lowercase, so I would suggest using `backport=<repo>:<branch>` for the labels.

Thanks for the advice!  I will change it to lowercase.

-------------

PR: https://git.openjdk.org/skara/pull/1466


More information about the skara-dev mailing list