RFR: 1706: Store github checks in PR unique way

Zhao Song zsong at openjdk.org
Thu Feb 9 22:01:13 UTC 2023

On Thu, 9 Feb 2023 21:52:16 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> > Checked the [checkrun](https://docs.github.com/en/rest/checks/runs?apiVersion=2022-11-28#get-a-check-run) document in GitHub and I found the document says there will be an `id` for every check-run. The document also says if we want to update the check-run, `id` is required in the header. But in `GitHubPullRequest#updateCheck`, I don't think we have anything related with `id`. Therefore I am wondering how could we update the check in GitHub, do we update the checks by the name?
> See comment at:
> https://github.com/openjdk/skara/blob/51956054485fce5cb42629c9696a3131cb098178/forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java#L454



PR: https://git.openjdk.org/skara/pull/1470

More information about the skara-dev mailing list