RFR: 1725: Clarify "no known role" error message [v2]

Guoxiong Li gli at openjdk.org
Fri Feb 10 11:22:57 UTC 2023


On Mon, 23 Jan 2023 18:40:49 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> A user reported that when people review PRs, the bot adds a list of reviewers into description. If a user is not registered in OpenJDK Census, a note is added: 
>> 
>> (no known github.com user name / role) 
>> 
>> What it actually means is "no known OpenJDK user name / role".
>> 
>> Github.com is being used here because we are utilizing the name of the namespace. However, the purpose of the namespace is to map users from this namespace to either openjdk or internal. Actually, we couldn't find the user in openjdk or internal, not in the namespace. The census repository name can indicate whether it is openjdk or internal.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix a problem

Now it becomes `no known openjdk user` and `no known oracle user`. Looks good if we can't find a good way to construct `OpenJDK` and `Oracle`.

-------------

Marked as reviewed by gli (Committer).

PR: https://git.openjdk.org/skara/pull/1459


More information about the skara-dev mailing list