RFR: 1706: Store github checks in PR unique way [v2]

Zhao Song zsong at openjdk.org
Fri Feb 10 22:15:23 UTC 2023

On Thu, 9 Feb 2023 22:40:42 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Currently, checks in GitHub are stored in the commit. So if multiple PRs share the same source commit, then they will compete with the check-runs and store their different checksum in there. This in turn means that all, or most of those PRs will always think the check is outdated when a CheckRun is performed next.
>> This patch adds repository name and pull request id to the name of check in Github. Therefore, even if multiple PRs share the same source commit, every PR will store a unique check in the commit and there is no competition exists.
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>   fix problems

> > Sorry, what I said is confusing. What I should say is that, jcheck is not triggered by the workflow, it is triggered by Checkrun. So it is not stored in the our own fork and then be copied to the pr.
> Right, but then how did we see all the different jcheck-- in the "checks" tab? Is that just github showing everything related to a commit? If so, I suppose it's ok, the naming should help telling them apart.

I think so. And this problem would happen only when we create multiple prs with same source commit in the **same** repository.


PR: https://git.openjdk.org/skara/pull/1470

More information about the skara-dev mailing list