RFR: 1706: Store github checks in PR unique way [v2]

Guoxiong Li gli at openjdk.org
Sat Feb 11 13:13:34 UTC 2023

On Fri, 10 Feb 2023 14:18:13 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> Because there is no concept of a "check" in GitLab. We just store the check results in a comment in the PR, so there is no reason to make the name of the check unique.

Thanks for the explanation.

> Until now my opinion was that the name of the jcheck check was something only the pull request bot module needed to know about, so putting that on the `PullRequest` interface didn't seem right. It was an implementation detail. But now since we need to share this information with testinfo, it would make sense to push this logic into `PullRequest`. The default method should in that case return "jcheck" and `GitHubPullRequest` can have the special implementation needed only on GitHub.

I understand what you considered. The name is indeed only used in PR bot. So now I think the current code is also okay.


PR: https://git.openjdk.org/skara/pull/1470

More information about the skara-dev mailing list