RFR: 1588: Bridge messages should not be sent for PRs in draft state [v3]
Guoxiong Li
gli at openjdk.org
Tue Feb 14 14:31:19 UTC 2023
On Tue, 14 Feb 2023 14:08:59 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Move the last draft invocation out of the method 'ignoreComment'. Adjust the API implementation.
>
> forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java line 713:
>
>> 711: .filter(obj -> obj.get("event").asString().equals("convert_to_draft"))
>> 712: .map(obj -> ZonedDateTime.parse(obj.get("created_at").asString()))
>> 713: .reduce((a, b) -> a.isBefore(b) ? b : a);
>
> I think this could be expressed as `max()`.
Fixed.
-------------
PR: https://git.openjdk.org/skara/pull/1469
More information about the skara-dev
mailing list