RFR: 1823: Mailing list bot should include link to comment on the Git forge

Zhao Song zsong at openjdk.org
Fri Feb 17 21:13:00 UTC 2023

On Fri, 17 Feb 2023 20:58:06 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> When publishing URLs in emails, we rewrite them to be (somewhat) forge agnostic. If you look in any PR email, you will not that it says "git.openjdk.org" and not github.com. This is a service we host that redirects to "github.com/openjdk". If we were to ever move to a different provider, we can change that rewrite service. Because of this, we can't use the URLs in the PR object for emails. We need to generate them.
> Since we don't need these URLs every time we fetch comments or reviews, I think it would make sense to let the PullRequest handle generation of these URLs, something like `PullRequest.reviewUrl(Review)` and `PullRequest.commentUrl(Comment)`, similar to the existing `PullRequest.changeUrl`.

Oh, got it. I will fix the problems. Thx!


PR: https://git.openjdk.org/skara/pull/1478

More information about the skara-dev mailing list