RFR: 1737: Draft PR for clean backport mistakenly marked as ready [v2]

[Erik Joelsson]

On Wed, 11 Jan 2023 23:59:46 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> 1. readyForIntegration for normal pr is determined by 
>> (1) whether there is any failed check 
>> (2) whether there is any additional errors 
>> (3) whether there is any uncompleted additional progress 
>> (4) whether there is any integration blocker 
>> 
>> So if there is a draft normal pr, there will always exist a failed check(ReviewersCheck will always fail because the pr is in draft mode and nobody will approve this pr) 
>> Therefore, a draft normal pr will not be marked as 'ready' because there is a failed check not because this pr is in draft mode. 
>> 
>> 2. readyForIntegration for clean backport is determined by 
>> (1) whether this pr is ready for review(TooFewReviewersIssue won't make it false) 
>> (2) whether there is any additional errors 
>> (3) whether there is any uncompleted additional progress 
>> (4) whether there is any integration blocker 
>> 
>> So if there is a draft clean backport pr, readyForIntegration will be true in most cases. 
>> Therefore, the clean backport pr will be marked as 'ready' whether it is in draft mode or not.
>> 
>> In this patch, whether there is an rfr label will determine whether readyforintegration is true or false.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   optimize how to determine readyForIntegration

Marked as reviewed by erikj (Lead).

-------------

PR: https://git.openjdk.org/skara/pull/1456