Integrated: 1737: Draft PR for clean backport mistakenly marked as ready
Zhao Song
zsong at openjdk.org
Thu Jan 12 18:01:41 UTC 2023
On Wed, 11 Jan 2023 22:51:35 GMT, Zhao Song <zsong at openjdk.org> wrote:
> 1. readyForIntegration for normal pr is determined by
> (1) whether there is any failed check
> (2) whether there is any additional errors
> (3) whether there is any uncompleted additional progress
> (4) whether there is any integration blocker
>
> So if there is a draft normal pr, there will always exist a failed check(ReviewersCheck will always fail because the pr is in draft mode and nobody will approve this pr)
> Therefore, a draft normal pr will not be marked as 'ready' because there is a failed check not because this pr is in draft mode.
>
> 2. readyForIntegration for clean backport is determined by
> (1) whether this pr is ready for review(TooFewReviewersIssue won't make it false)
> (2) whether there is any additional errors
> (3) whether there is any uncompleted additional progress
> (4) whether there is any integration blocker
>
> So if there is a draft clean backport pr, readyForIntegration will be true in most cases.
> Therefore, the clean backport pr will be marked as 'ready' whether it is in draft mode or not.
>
> In this patch, whether there is an rfr label will determine whether readyforintegration is true or false.
This pull request has now been integrated.
Changeset: bbb3595a
Author: Zhao Song <zsong at openjdk.org>
URL: https://git.openjdk.org/skara/commit/bbb3595ac2bccc4ecc8fd6508a2375b86562cc04
Stats: 10 lines in 1 file changed: 2 ins; 1 del; 7 mod
1737: Draft PR for clean backport mistakenly marked as ready
Reviewed-by: erikj
-------------
PR: https://git.openjdk.org/skara/pull/1456
More information about the skara-dev
mailing list