RFR: 1789: Skara PR commands are not interpreted on Github review comments

Erik Joelsson erikj at openjdk.org
Wed Jan 18 20:07:20 UTC 2023

On Wed, 18 Jan 2023 18:08:54 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> A user reported that Skara bots were not responding to commands in review comments or the body of a review. 
>> This patch addresses that issue by ensuring that the Skara bots can correctly detect and interpret commands.
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCommandWorkItem.java line 245:
>> 243:         comments.addAll(pr.reviewComments().stream()
>> 244:                 .map(reviewComment -> new Comment("ReviewComment" + reviewComment.id(), reviewComment.body(), reviewComment.author(), reviewComment.createdAt(), reviewComment.updatedAt()))
>> 245:                 .toList());
> I am not sure if the "review", "review comment", and "comment" in Github refer to the same numbering system, but based on my experiments, it is likely that they have their own independent numbering system. Although the probability of ID conflicts is small, I think it would be better to add "review" before the ID of a review, and "ReviewComment" before the ID of a review comment.

Have you found a conflict? I did a quick check and didn't find any, but that's definitely no guarantee.


PR: https://git.openjdk.org/skara/pull/1458

More information about the skara-dev mailing list