RFR: 1789: Skara PR commands are not interpreted on Github review comments [v2]
zsong at openjdk.org
Wed Jan 18 21:44:45 UTC 2023
On Wed, 18 Jan 2023 20:39:38 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
> > In the description of the bug, Magnus said "I guess the same goes if you would make a single comment in review mode as well, but I have not tested this. ". I thought he would expect the command in single comment(which is reviewComment) could be interpreted too. I don't know whether we need it or not.
> You are right, I misinterpreted that part.
> > I am a bit uncertain about PR commands in review comments. I don't think there is much of a use case for that, and if it is costly for us to process, I think we can skip it. But otoh, if the overhead is not an issue, I think having a consistent UX is a good thing. If someone were to be adding a PR command in a comment, they will be surprised if it doesn't work.
> My concern is that review threads can be marked as resolved and no longer visible. They can also be hard to find if the author force pushes to the source branch. It makes it hard to backtrack through the comment history to understand when a command was issued.
Due to Erik's concern, I think it would be better to temporarily disregard commands within ReviewComments. If a use case for this feature is identified in the future, we can revisit the topic.
More information about the skara-dev