RFR: 1789: Skara PR commands are not interpreted on Github review comments [v2]

David Holmes dholmes at openjdk.org
Thu Jan 19 06:44:34 UTC 2023

On Wed, 18 Jan 2023 21:41:03 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> A user reported that Skara bots were not responding to commands in review comments or the body of a review. 
>> This patch addresses that issue by ensuring that the Skara bots can correctly detect and interpret commands.
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>   sort comments by created time

I also have misgivings about scanning review comments for PR commands - so it seems there is consensus there. 

Even in the main review comment what gets scanned - all the text? Only the start of lines? I would worry about text being misconstrued as a command. This would especially be true for skara PRs where review comments may well refer to PR commands as part of the discussion.


PR: https://git.openjdk.org/skara/pull/1458

More information about the skara-dev mailing list