RFR: 1789: Skara PR commands are not interpreted on Github review comments [v3]

Erik Joelsson erikj at openjdk.org
Thu Jan 19 19:36:22 UTC 2023

On Thu, 19 Jan 2023 17:41:27 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> A user reported that Skara bots were not responding to commands in review comments or the body of a review. 
>> This patch addresses that issue by ensuring that the Skara bots can correctly detect and interpret commands.
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>   remove some comments and add tests

Marked as reviewed by erikj (Lead).

bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCommandWorkItem.java line 237:

> 235:     private List<Comment> getAllComments() {
> 236:         // Regular comments
> 237:         List<Comment> comments = new ArrayList<>(prComments());

It's not really important, but you could use Streams.concat() instead of creating two intermediate lists.


PR: https://git.openjdk.org/skara/pull/1458

More information about the skara-dev mailing list