RFR: 1806: Optimize the CSR progress message and log when CSR not found [v4]
Erik Joelsson
erikj at openjdk.org
Fri Jan 27 15:12:45 UTC 2023
On Fri, 27 Jan 2023 01:00:53 GMT, Zhao Song <zsong at openjdk.org> wrote:
>> A user reported that she have a PR which can't find its corresponding CSR.
>> Erik found that the issue was caused by the user not updating their branch in a long time, and the fixVersion in the .jcheck/conf file was still set at 20. However, the fixVersion of the CSR was 21, make the bot unable to locate the corresponding CSR.
>>
>> In this patch, I optimized the CSR progress message and log.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>
> fix a problem
bots/common/src/main/java/org/openjdk/skara/bots/common/BotUtils.java line 48:
> 46: if(confFile == null){
> 47: return Optional.empty();
> 48: }
Suggestion:
if (confFile == null) {
return Optional.empty();
}
-------------
PR: https://git.openjdk.org/skara/pull/1463
More information about the skara-dev
mailing list