RFR: 1925: When archiving a comment, mlbridgeBot would strip everything after the first command

Zhao Song zsong at openjdk.org
Fri Jun 2 16:43:56 UTC 2023

On Fri, 2 Jun 2023 16:28:22 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> According to the previous logic, for example, if we approve a PR and the review body only contains command like "/reviewers 2", then this review will be ignored. This issue is what I want to resolve.
>> But now I also think something in my logic is wrong.
> See this PR that I reviewed this morning: https://github.com/openjdk/jdk/pull/14261
> I didn't put any text in the review comment/body, but we still had this email sent: https://mail.openjdk.org/pipermail/build-dev/2023-June/039655.html

Yes, empty body is good. But if and only if the review body only contains command, it will be ignored. 

Just like when you are approving the pr, you put "/reviewers 2"(or any other command) in the review body.


PR Review Comment: https://git.openjdk.org/skara/pull/1524#discussion_r1214593997

More information about the skara-dev mailing list