RFR: 1925: When archiving a comment, mlbridgeBot would strip everything after the first command

Erik Joelsson erikj at openjdk.org
Fri Jun 2 17:11:18 UTC 2023

On Thu, 1 Jun 2023 22:22:25 GMT, Zhao Song <zsong at openjdk.org> wrote:

> A user reported that there is no email generated for this comment. 
> https://github.com/openjdk/jdk/pull/14114#issuecomment-1562126987 
> It is caused by the initial `/csr needed` command. The root cause is that in `ArchiveWorkItem#ignoreComment`, any command would be treated as a multiline command. 
> The logic about filtering out commands from a comment differs between `ArchiveWorkItem#ignoreComment` and `CommandExtractor#extractCommands`.
> In this patch, I make the logic consistent in this two methods.
> 1. Any line starts with '/' followed by lowercase characters will be recognized as a command line. The command line will be stripped. 
> 2. Check whether this command is a multiline command. If so, the following lines will be considered as arguments of the command and the argument lines will be stripped until the bot found another command line.

Marked as reviewed by erikj (Lead).


PR Review: https://git.openjdk.org/skara/pull/1524#pullrequestreview-1458066177

More information about the skara-dev mailing list