RFR: 1554: Fold JEPBot into PR bot [v2]

Zhao Song zsong at openjdk.org
Tue Jun 27 16:08:11 UTC 2023

On Tue, 27 Jun 2023 13:01:44 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 330:
>>> 328: 
>>> 329:         var issueProject = issueProject();
>>> 330:         if (issueProject != null) {
>> Do we still need to check `issueProject ` here?
> I'm not completely sure, but if we don't, there is a risk that we change behavior when a bot is configured without an issue tracker/project. It would be a good followup to really investigate if that should be a valid configuration and how that is supposed to work.

Sure. It's no harm to keep the check here.


PR Review Comment: https://git.openjdk.org/skara/pull/1535#discussion_r1244001411

More information about the skara-dev mailing list