RFR: 1199: Enforce maintainer approval in JBS before allowing to integrate backports into updates projects

[Erik Joelsson]

On Tue, 27 Jun 2023 21:37:35 GMT, Zhao Song <zsong at openjdk.org> wrote:

> As Erik said in the description of this issue, currently, this issue only cares about tracking approval labels in the related bugs.
> 
> If a repository is set up with the "approval" configuration, pull requests in that repository will require the maintainer's approval in JBS. Otherwise, the pull request will not be considered ready. 
> 
> Erik has also provided a design outlining how to configure the "approval" for a repository.
> 
> 
> The simple case, where the labels are the same for every branch in a repository: 
> 
> "approval": { 
>   "request": "jdk17u-fix-request", 
>   "approved": "jdk17u-fix-yes", 
>   "rejected": "jdk17u-fix-no", 
> } 
> 
> To reduce the need for changing multiple strings when copying a configuration for a new repository, there is an optional "prefix" field: 
> 
> "approval": { 
>   "prefix": "jdk17u-fix-", 
>   "request": "request", 
>   "approved": "yes", 
>   "rejected": "no", 
> } 
> 
> When there are multiple branches with different labels, having the prefix set per branch can help reduce the size of the configuration significantly: 
> 
> "approval": { 
>   "request": "-critical-request", 
>   "approved": "-critical-approved", 
>   "rejected": "-critical-rejected", 
>   "branches": [ 
>     "jdk20\.0\.1": { "prefix": "CPU23_04" } 
>   ] 
> }

When a PR is ready with everything but approval, we should also update the status comment with a helpful message linking to the approval process. This is the same comment where the "ready to integrate" message is posted. That link needs to be configurable.

-------------

PR Comment: https://git.openjdk.org/skara/pull/1537#issuecomment-1611428897