RFR: 1199: Enforce maintainer approval in JBS before allowing to integrate backports into updates projects

Zhao Song zsong at openjdk.org
Thu Jun 29 16:46:29 UTC 2023

On Wed, 28 Jun 2023 13:36:34 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> When a PR is ready with everything but approval, we should also update the status comment with a helpful message linking to the approval process. This is the same comment where the "ready to integrate" message is posted. That link needs to be configurable.

Do you mean the `mergeReadyComment`?(I saw your comment in the issue description) But currently, the maintainer approval is a `progress`. The PR would not be considered ready without maintainer approval label in the related issue, and the mergeReadyComment would not be posted unless the PR is considered ready.


PR Comment: https://git.openjdk.org/skara/pull/1537#issuecomment-1613516298

More information about the skara-dev mailing list