RFR: 1199: Enforce maintainer approval in JBS before allowing to integrate backports into updates projects

[Erik Joelsson]

On Thu, 29 Jun 2023 16:44:08 GMT, Zhao Song <zsong at openjdk.org> wrote:

> > When a PR is ready with everything but approval, we should also update the status comment with a helpful message linking to the approval process. This is the same comment where the "ready to integrate" message is posted. That link needs to be configurable.
> 
> Do you mean the `mergeReadyComment`?(I saw your comment in the issue description) But currently, the maintainer approval is a `progress`. The PR would not be considered ready without maintainer approval label in the related issue, and the mergeReadyComment would not be posted unless the PR is considered ready.

That's what I meant. This would mean that we post the comment earlier and that we should rename the concept of that comment to something like `nextStepComment`. But maybe we shouldn't use the same comment, but instead introduce a new `approvalNeededComment`. Otherwise there is risk that it gets lost in the list of comments after a while. This new comment would be added when only the approval is left to do. Later in [SKARA-1949](https://bugs.openjdk.org/browse/SKARA-1949), the contents of this comment would be expanded to contain instructions for how to apply for maintainer approval using Skara commands. For now it can only reference the process documentation.

-------------

PR Comment: https://git.openjdk.org/skara/pull/1537#issuecomment-1614311305