RFR: 1843: mlbridge bot bridge emails generated by itself.

Zhao Song zsong at openjdk.org
Thu Mar 16 15:43:50 UTC 2023

On Thu, 16 Mar 2023 05:20:54 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> This patch filters both `github.com` (by `authenticatedUrl()`) and `git.openjdk.com` (by `url()`) in `MailingListArchiveReaderBot::inspect` to avoid the bot posting the unnecessary comments to the PRs. Please see SKARA-1843 [1] for more information.
> But I can't write a test case for it now, because the current URLs of the repositories in test code are fake and their host are empty, which means both `pr.repository().url().getHost()` and `pr.repository().authenticatedUrl().getHost()` always return `null`.
> Thanks for the review.
> Best Regards,
> -- Guoxiong
> [1] https://bugs.openjdk.org/browse/SKARA-1843

I will check other places where we changed `authenticatedUrl().getHost()` to `url().getHost()` in SKARA-1813.


PR Comment: https://git.openjdk.org/skara/pull/1485#issuecomment-1472222138

More information about the skara-dev mailing list