RFR: 1838: better error message when download fails [v2]

Erik Joelsson erikj at openjdk.org
Thu Mar 16 19:54:16 UTC 2023

On Thu, 16 Mar 2023 19:10:50 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Sometimes, users may want to run jcheck locally before creating PRs. However, Oracle employees who are connected to the Oracle VPN and have not set the https_proxy environment variable may encounter a "connect exception" error. 
>> In this patch, we will provide users with more information in the case of a "connect exception" error while running jcheck.
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>   Update cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java
>   Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>

cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java line 352:

> 350:             } catch (Exception e) {
> 351:                 System.err.println(String.format("error: exception thrown during jcheck: %s", e.getMessage()));
> 352:                 if (e.getMessage().equals("java.net.ConnectException")) {

I forgot to look at the rest of the code. I think this should be an `instanceof` check instead of comparing strings.


PR Review Comment: https://git.openjdk.org/skara/pull/1486#discussion_r1139287193

More information about the skara-dev mailing list