RFR: 1838: better error message when download fails [v2]

[Zhao Song]

On Thu, 16 Mar 2023 19:51:55 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java
>>   
>>   Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
>
> cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java line 352:
> 
>> 350:             } catch (Exception e) {
>> 351:                 System.err.println(String.format("error: exception thrown during jcheck: %s", e.getMessage()));
>> 352:                 if (e.getMessage().equals("java.net.ConnectException")) {
> 
> I forgot to look at the rest of the code. I think this should be an `instanceof` check instead of comparing strings.

Sure

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1486#discussion_r1139340414