RFR: 1843: mlbridge bot bridge emails generated by itself.

Guoxiong Li gli at openjdk.org
Thu Mar 16 22:18:59 UTC 2023

On Thu, 16 Mar 2023 18:34:15 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Just a reminder, If so, we should also change `return EmailAddress.from(encodedCommon + "." + UUID.randomUUID() + "@" + pr.repository().url().getHost())` in `ReviewArchive::getUniqueMessageId ` to `return EmailAddress.from(encodedCommon + "." + UUID.randomUUID() + "@" + pr.repository().authenticatedUrl().getHost())`
> Yes, right, we are currently generating `Message-ID`s with the rewritten url. That's bad. We should make sure they are all reverted to github.com.

If we only filter the `authenticatedUrl`, what about the polluted data? The SKARA project now has many emails which have the message id with `git.openjdk.org`. If we don’t filter them, they would be posted as comments.


PR Review Comment: https://git.openjdk.org/skara/pull/1485#discussion_r1139411065

More information about the skara-dev mailing list