RFR: 1843: mlbridge bot bridges emails generated by itself [v2]

Erik Joelsson erikj at openjdk.org
Fri Mar 17 12:55:21 UTC 2023

On Thu, 16 Mar 2023 22:16:44 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Yes, right, we are currently generating `Message-ID`s with the rewritten url. That's bad. We should make sure they are all reverted to github.com.
> If we only filter the `authenticatedUrl`, what about the polluted data? The SKARA project now has many emails which have the message id with `git.openjdk.org`. If we don’t filter them, they would be posted as comments.

Yes, but it's only the Skara project, so I was ok with living with it. But sure, we can keep the double filter if we add the following comment.

        // Filter on both original, and any pattern replaced, host for now as we have polluted
        // data in the Skara project mail archives. We should revert this to just authenticatedUrl
        // eventually.
        var bridgeIdStr = "^[^.]+\.[^.]+@(?:" + pr.repository().url().getHost() + "|" + pr.repository().authenticatedUrl().getHost() + ")$";
        var bridgeIdPattern = Pattern.compile(bridgeIdStr);


PR Review Comment: https://git.openjdk.org/skara/pull/1485#discussion_r1140199035

More information about the skara-dev mailing list