RFR: 1843: mlbridge bot bridges emails generated by itself [v3]

Erik Joelsson erikj at openjdk.org
Fri Mar 17 13:44:41 UTC 2023

On Fri, 17 Mar 2023 13:25:36 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> This patch filters both `github.com` (by `authenticatedUrl()`) and `git.openjdk.com` (by `url()`) in `MailingListArchiveReaderBot::inspect` to avoid the bot posting the unnecessary comments to the PRs. Please see SKARA-1843 [1] for more information.
>> But I can't write a test case for it now, because the current URLs of the repositories in test code are fake and their host are empty, which means both `pr.repository().url().getHost()` and `pr.repository().authenticatedUrl().getHost()` always return `null`.
>> Thanks for the review.
>> Best Regards,
>> -- Guoxiong
>> [1] https://bugs.openjdk.org/browse/SKARA-1843
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>   Use the simple pattern.

Marked as reviewed by erikj (Lead).


PR Review: https://git.openjdk.org/skara/pull/1485#pullrequestreview-1345974226

More information about the skara-dev mailing list