RFR: 1830: Support wildcard branch protection with prbranches

Zhao Song zsong at openjdk.org
Mon Mar 20 22:58:47 UTC 2023

On Mon, 20 Mar 2023 22:37:32 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> bots/notify/src/main/java/org/openjdk/skara/bots/notify/prbranch/PullRequestBranchNotifier.java line 67:
>>> 65:         if (protectBranches) {
>>> 66:             log.info("Removing branch protection for " + branch);
>>> 67:             pr.repository().unprotectBranchPattern(branch);
>> We still need this because it's possible that we have some pr branch protected before we deploy this patch.
> You should add a code comment explaining this so we may eventually remove that code later.
> Have you checked how the call behaves if there is no protection to remove?

Sure, will add the comment. No, I didn't check it by myself because I saw your test in `GitLabRestApiTest::branchProtection`. I will check it again later.


PR Review Comment: https://git.openjdk.org/skara/pull/1489#discussion_r1142752422

More information about the skara-dev mailing list