RFR: 1830: Support wildcard branch protection with prbranches [v2]
Zhao Song
zsong at openjdk.org
Mon Mar 20 23:22:42 UTC 2023
On Mon, 20 Mar 2023 22:56:26 GMT, Zhao Song <zsong at openjdk.org> wrote:
>> You should add a code comment explaining this so we may eventually remove that code later.
>>
>> Have you checked how the call behaves if there is no protection to remove?
>
> Sure, will add the comment. No, I didn't check it by myself because I saw your test in `GitLabRestApiTest::branchProtection`. I will check it again later.
Checked it again, if there is no protection to remove, nothing would happen. The bot works fine.
-------------
PR Review Comment: https://git.openjdk.org/skara/pull/1489#discussion_r1142764781
More information about the skara-dev
mailing list