RFR: 1851: Fold CSR bot into PR bot

Zhao Song zsong at openjdk.org
Mon Mar 27 23:07:38 UTC 2023


On Mon, 27 Mar 2023 22:27:43 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> In this patch, the whole csr bot module is removed. 
>> 
>> Original CSRPullRequestBot is deleted. The functionality of this bot has been moved to `CheckRun`.
>> 
>> Original CSRIssueBot has been moved to pr bot module. PullRequestBotFactory would generate a CSRIssueBot for every configured Issue project.
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CSRIssueBot.java line 54:
> 
>> 52:         this.pullRequestBotMap = pullRequestBotMap;
>> 53:         // The CSRPullRequestBot will initially evaluate all active PRs so there
>> 54:         // is no need to look at any issues older than the start time of the bot
> 
> This comment needs to be updated.

Sure, will update it.

> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 1287:
> 
>> 1285:     }
>> 1286: 
>> 1287:     void updateCSRLabel(List<Issue> issues) {
> 
> Why not private?

Yes, it would be better to make it private, will fix it.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1492#discussion_r1149868330
PR Review Comment: https://git.openjdk.org/skara/pull/1492#discussion_r1149868682


More information about the skara-dev mailing list