RFR: 1851: Fold CSR bot into PR bot

Erik Joelsson erikj at openjdk.org
Mon Mar 27 23:13:53 UTC 2023

On Mon, 27 Mar 2023 21:48:23 GMT, Zhao Song <zsong at openjdk.org> wrote:

> In this patch, the whole csr bot module is removed. 
> Original CSRPullRequestBot is deleted. The functionality of this bot has been moved to `CheckRun`.
> Original CSRIssueBot has been moved to pr bot module. PullRequestBotFactory would generate a CSRIssueBot for every configured Issue project.

bots/pr/src/test/java/org/openjdk/skara/bots/pr/CSRTests.java line 453:

> 451: 
> 452:             // The bot should reply with a message that there is already an approved
> 453:             // Now CheckWorkItem is responsible for updating CSR label, so before 'csr' is handled, csr label is added to this pr

I don't understand this comment.

bots/pr/src/test/java/org/openjdk/skara/bots/pr/PullRequestBotFactoryTest.java line 173:

> 171:             assertNotNull(csrIssueBot2.getPRBot("repo2"));
> 172:             assertNotNull(csrIssueBot2.getPRBot("repo5"));
> 173:             assertNotNull(csrIssueBot2.getPRBot("repo6"));

This doesn't look right. An instance of `CSRIssueBot` should only have access to `PullRequestBot` instances for repositories that share the same IssueProject.


PR Review Comment: https://git.openjdk.org/skara/pull/1492#discussion_r1149867142
PR Review Comment: https://git.openjdk.org/skara/pull/1492#discussion_r1149871746

More information about the skara-dev mailing list