RFR: 1851: Fold CSR bot into PR bot

Zhao Song zsong at openjdk.org
Mon Mar 27 23:18:20 UTC 2023


On Mon, 27 Mar 2023 23:02:39 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> In this patch, the whole csr bot module is removed. 
>> 
>> Original CSRPullRequestBot is deleted. The functionality of this bot has been moved to `CheckRun`.
>> 
>> Original CSRIssueBot has been moved to pr bot module. PullRequestBotFactory would generate a CSRIssueBot for every configured Issue project.
>
> bots/pr/src/test/java/org/openjdk/skara/bots/pr/CSRTests.java line 453:
> 
>> 451: 
>> 452:             // The bot should reply with a message that there is already an approved
>> 453:             // Now CheckWorkItem is responsible for updating CSR label, so before 'csr' is handled, csr label is added to this pr
> 
> I don't understand this comment.

Sorry, somehow the sentence is truncated.  Will update the comment

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1492#discussion_r1149874267


More information about the skara-dev mailing list