RFR: 1851: Fold CSR bot into PR bot

Zhao Song zsong at openjdk.org
Mon Mar 27 23:23:23 UTC 2023

On Mon, 27 Mar 2023 23:11:25 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> In this patch, the whole csr bot module is removed. 
>> Original CSRPullRequestBot is deleted. The functionality of this bot has been moved to `CheckRun`.
>> Original CSRIssueBot has been moved to pr bot module. PullRequestBotFactory would generate a CSRIssueBot for every configured Issue project.
> bots/pr/src/test/java/org/openjdk/skara/bots/pr/PullRequestBotFactoryTest.java line 173:
>> 171:             assertNotNull(csrIssueBot2.getPRBot("repo2"));
>> 172:             assertNotNull(csrIssueBot2.getPRBot("repo5"));
>> 173:             assertNotNull(csrIssueBot2.getPRBot("repo6"));
> This doesn't look right. An instance of `CSRIssueBot` should only have access to `PullRequestBot` instances for repositories that share the same IssueProject.

At first, I had the same idea with you and later I found it a little complex to implement it. But if we let all CSRIssueBots share a map, it would be very easy. If you think it's necessary to change, I will fix it.


PR Review Comment: https://git.openjdk.org/skara/pull/1492#discussion_r1149876593

More information about the skara-dev mailing list