RFR: 1851: Fold CSR bot into PR bot [v2]

Zhao Song zsong at openjdk.org
Tue Mar 28 01:02:48 UTC 2023

On Mon, 27 Mar 2023 22:58:49 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>>   fix problems
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java line 278:
>> 276:         var activeReviews = CheckablePullRequest.filterActiveReviews(allReviews, pr.targetRef());
>> 277:         // Determine if the current state of the PR has already been checked
>> 278:         if (forceUpdate || !currentCheckValid(census, comments, activeReviews, labels)) {
> Forcing an update is one way of solving this. It may turn out to trigger too many updates. If so we will need to think about how we can identify relevant changes to the issue, or at least filter out obviously irrelevant changes. We only really care about state changes.

Yes, you're right. Currently, any change to a csr issue would trigger update to the relevant pr. I will try to get the activities of the csr issue.


PR Review Comment: https://git.openjdk.org/skara/pull/1492#discussion_r1149920752

More information about the skara-dev mailing list