RFR: 1851: Fold CSR bot into PR bot
Zhao Song
zsong at openjdk.org
Tue Mar 28 00:48:30 UTC 2023
On Mon, 27 Mar 2023 22:37:25 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> In this patch, the whole csr bot module is removed.
>>
>> Original CSRPullRequestBot is deleted. The functionality of this bot has been moved to `CheckRun`.
>>
>> Original CSRIssueBot has been moved to pr bot module. PullRequestBotFactory would generate a CSRIssueBot for every configured Issue project.
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 1318:
>
>> 1316: }
>> 1317:
>> 1318: var csrOptional = Backports.findCsr(jbsIssueOpt.get(), versionOpt.get());
>
> Can this be unified with the `getCsrIssueTrackerIssues` call right before this method is called? We shouldn't need to fetch CSR issues more than once.
Yes, we can. Fixed it.
-------------
PR Review Comment: https://git.openjdk.org/skara/pull/1492#discussion_r1149915237
More information about the skara-dev
mailing list