RFR: 1851: Fold CSR bot into PR bot [v3]
Zhao Song
zsong at openjdk.org
Tue Mar 28 22:23:38 UTC 2023
On Tue, 28 Mar 2023 22:06:26 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Zhao Song has updated the pull request incrementally with four additional commits since the last revision:
>>
>> - fix a problem
>> - fix a problem
>> - renamed some classes
>> - improve PullRequestBotFactoryTest
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CSRIssueWorkItem.java line 115:
>
>> 113: }
>> 114:
>> 115: @Override
>
> Should probably change the `workItemName` to something like "csrissue".
Will change it
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestWorkItem.java line 62:
>
>> 60: this.prId = prId;
>> 61: this.errorHandler = errorHandler;
>> 62: this.triggerUpdatedAt = prUpdatedAt;
>
> I like the new naming of this field, but please also update the parameter in the constructor.
Sure
-------------
PR Review Comment: https://git.openjdk.org/skara/pull/1492#discussion_r1151205901
PR Review Comment: https://git.openjdk.org/skara/pull/1492#discussion_r1151205765
More information about the skara-dev
mailing list