RFR: 1859: Add "tags only" option to MirrorBot [v2]

Zhao Song zsong at openjdk.org
Wed Mar 29 16:07:39 UTC 2023

On Wed, 29 Mar 2023 11:42:13 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Hi all,
>> please review this patch that adds an option to the `MirrorBot` to mirror only tags from one repository to another. I also added some additional logging to `MirrorBot` and cleaned up the logic a bit for selecting the "mode" (tags, mirror, selected branches) that the `MirrorBot` uses.
>> ### Testing
>> - [x] Added one additional unit test
>> Thanks,
>> Erik
> Erik Helin has updated the pull request incrementally with one additional commit since the last revision:
>   Reviewer feeback

bots/mirror/src/test/java/org/openjdk/skara/bots/mirror/MirrorBotFactoryTest.java line 234:

> 232:                           "to": "to4",
> 233:                           "tags": "exclude"
> 234:                         },

I am wondering what's the expected behavior for the mirror bot configured like this? Intuitively speaking, I think the bot should mirror every branch but excluding tags. But currently, the bot would not mirror anything. if i am wrong please correct me. Thank you!


PR Review Comment: https://git.openjdk.org/skara/pull/1493#discussion_r1152173992

More information about the skara-dev mailing list