RFR: 1859: Add "tags only" option to MirrorBot [v2]
Erik Helin
ehelin at openjdk.org
Fri Mar 31 13:03:15 UTC 2023
On Thu, 30 Mar 2023 18:29:20 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> bots/mirror/src/test/java/org/openjdk/skara/bots/mirror/MirrorBotFactoryTest.java line 234:
>>
>>> 232: "to": "to4",
>>> 233: "tags": "exclude"
>>> 234: },
>>
>> I am wondering what's the expected behavior for the mirror bot configured like this? Intuitively speaking, I think the bot should mirror every branch but excluding tags. But currently, the bot would not mirror anything. if i am wrong please correct me. Thank you!
>
> I believe you are correct, this config will mirror nothing, but I agree that the expectation would be to mirror all branches but no tags.
Yep, realized this after I pushed. I decided to remove `"exclude"` in the latest commit since implementing it is quite cumbersome (the `git` CLI client doesn't have a `--no-tags` option for `git push`).
-------------
PR Review Comment: https://git.openjdk.org/skara/pull/1493#discussion_r1154445921
More information about the skara-dev
mailing list