RFR: 1340: Correct email domain not always used when adding a contributor to a PR

Guoxiong Li gli at openjdk.org
Fri May 5 18:09:50 UTC 2023

On Fri, 5 May 2023 17:06:52 GMT, Zhao Song <zsong at openjdk.org> wrote:

> Now, the email domain for additional contributors is always the default "openjdk.org" domain because we hardcoded it.
> To resolve this issue, we should use the domain in jcheck configuration file.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/ContributorCommand.java line 90:

> 88: 
> 89:         if (contributor.fullName().isPresent()) {
> 90:             return Optional.of(EmailAddress.from(contributor.fullName().get(), contributor.username() + "@" + censusInstance.configuration.census().domain()));

The `configuration` is a private field in class `CensusInstance`, so we should use the getter method `configuration()`. But it is curious that the building and testing of the `Pre-submit tests` succeeded.


PR Review Comment: https://git.openjdk.org/skara/pull/1513#discussion_r1186373511

More information about the skara-dev mailing list