RFR: 1340: Correct email domain not always used when adding a contributor to a PR [v2]

[Zhao Song]

On Fri, 5 May 2023 18:07:36 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix a problem
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/ContributorCommand.java line 90:
> 
>> 88: 
>> 89:         if (contributor.fullName().isPresent()) {
>> 90:             return Optional.of(EmailAddress.from(contributor.fullName().get(), contributor.username() + "@" + censusInstance.configuration.census().domain()));
> 
> The `configuration` is a private field in class `CensusInstance`, so we should use the getter method `configuration()`. But it is curious that the building and testing of the `Pre-submit tests` succeeded.

Thanks for catching it!

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1513#discussion_r1186375436