RFR: 1340: Correct email domain not always used when adding a contributor to a PR [v3]

Erik Joelsson erikj at openjdk.org
Fri May 5 21:18:05 UTC 2023

On Fri, 5 May 2023 18:35:23 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Now, the email domain for additional contributors is always the default "openjdk.org" domain because we hardcoded it.
>> To resolve this issue, we should use the domain in jcheck configuration file.
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>   add a test

Marked as reviewed by erikj (Lead).

bots/pr/src/main/java/org/openjdk/skara/bots/pr/ContributorCommand.java line 90:

> 88: 
> 89:         if (contributor.fullName().isPresent()) {
> 90:             return Optional.of(EmailAddress.from(contributor.fullName().get(), contributor.username() + "@" + censusInstance.configuration().census().domain()));

Could do with a line break here to make it more readable, especially in diffs.


PR Review: https://git.openjdk.org/skara/pull/1513#pullrequestreview-1415463233
PR Review Comment: https://git.openjdk.org/skara/pull/1513#discussion_r1186503001

More information about the skara-dev mailing list