RFR: 1340: Correct email domain not always used when adding a contributor to a PR [v3]

Zhao Song zsong at openjdk.org
Fri May 5 23:07:23 UTC 2023


On Fri, 5 May 2023 21:10:31 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add a test
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/ContributorCommand.java line 90:
> 
>> 88: 
>> 89:         if (contributor.fullName().isPresent()) {
>> 90:             return Optional.of(EmailAddress.from(contributor.fullName().get(), contributor.username() + "@" + censusInstance.configuration().census().domain()));
> 
> Could do with a line break here to make it more readable, especially in diffs.

Sure

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1513#discussion_r1186549092


More information about the skara-dev mailing list