Integrated: 1332: Skara sometimes fails to detect that a backport was clean
Zhao Song
zsong at openjdk.org
Mon May 8 21:05:29 UTC 2023
On Mon, 8 May 2023 19:45:59 GMT, Zhao Song <zsong at openjdk.org> wrote:
> The pr bot sometimes fails to detect a backport is clean.
>
> This issue for GitHub part was resolved by Guoxiong Li in [SKARA-1406](https://bugs.openjdk.org/browse/SKARA-1406).
>
> This issue for GitLab part will be resolved in this patch.
>
> Investigated some GitLab MR examples, I found that although the GitLab UI shows there are diffs in some files, when the bot queries changes of the pr, GitLab would tell the bot there are no diffs in some files.
>
> After reading the GitLab Api document, I found that we should set `access_raw_diffs` to `true` to get all the diffs.
>
> https://docs.gitlab.com/ee/api/merge_requests.html#get-single-merge-request-changes
This pull request has now been integrated.
Changeset: 0043fdf3
Author: Zhao Song <zsong at openjdk.org>
URL: https://git.openjdk.org/skara/commit/0043fdf3aab5a5dee4ad6e35915bb7962b39ce2e
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
1332: Skara sometimes fails to detect that a backport was clean
Reviewed-by: erikj
-------------
PR: https://git.openjdk.org/skara/pull/1515
More information about the skara-dev
mailing list