RFR: 1907: PR should not be integrated with the temporary issue failure
zsong at openjdk.org
Wed May 10 23:33:53 UTC 2023
On Wed, 10 May 2023 18:12:20 GMT, Zhao Song <zsong at openjdk.org> wrote:
> In SKARA-1899, we stopped all notifiers if the bot found temporary issue failure because we think it's just temporary issue failure and once the failure got resolved, the notifiers will be triggered again. However, it will introduce a new problem. If the pr is integrated when the temporary issue failure is happening, the notifiers will not be trigger again because the pr bot will not update integrated pr body.
> Also, if the pr is integrated with the temporary issue failure, it would make the issue never get resolved.
> In this patch, the conditions for stopping notifiers have been tightened. Besides, the pr bot would not mark a pr as ready is the pr body contains `TEMPORARY_ISSUE_FAILURE_MARKER`
Now, I think the pr bot should not mark the pr as ready if the temporary issue failure happens. And it's the easiest way to ensure the issue notifier would work well after the pr is integrated.
PR Comment: https://git.openjdk.org/skara/pull/1518#issuecomment-1542844938
More information about the skara-dev