RFR: 1907: PR should not be integrated with the temporary issue failure

Erik Joelsson erikj at openjdk.org
Thu May 11 20:10:33 UTC 2023

On Wed, 10 May 2023 21:42:20 GMT, Zhao Song <zsong at openjdk.org> wrote:

> Now, I think the pr bot should not mark the pr as ready if the temporary issue failure happens. And it's the easiest way to ensure the issue notifier would work well after the pr is integrated.

That's probably a good idea, but not enough to cover us here. When the ready label is added, this will trigger another `CheckWorkItem` (PullRequestBot will find the PR updated) and `CheckRun` (label change invalidates the cached metadata). It looks like that after `IntegrateCommand` is run, the `PullRequestCommandWorkItem` will not schedule another `CheckWorkItem`. Also the `PullRequestBot` will never schedule `CheckWorkItem` for a PR that isn't open, and the `CheckWorkItem` has an early exit if the PR is integrated. So, I think we need to make sure the PR cannot integrate with the TEMPORARY_ISSUE_FAILURE_MARKER present.


PR Comment: https://git.openjdk.org/skara/pull/1518#issuecomment-1544608554

More information about the skara-dev mailing list