RFR: 1910: Basic support for Bitbucket as a Forge [v2]

Erik Joelsson erikj at openjdk.org
Fri May 12 23:00:47 UTC 2023

On Fri, 12 May 2023 22:10:46 GMT, Zhao Song <zsong at openjdk.org> wrote:

> In general, this patch looks good to me! Just a few minor problems. First, I think the new files need copyright header. Then, the GHA failed due to compile error, we need to import `org.openjdk.skara.cli.ForgeUtils` in `GitPrCreate` explicitly. Additionally, have you attempted to run a mirror bot using a BitBucket repo as the source on your local machine? If so, I believe this patch will work fine!

Thanks the feedback! Added copyright, completely forgot about that. To fix ForgeUtils, I moved it to a new package called "internal" instead. It's not meant to be exported to other modules.

Yes, I have run a local mirror configuration to verify the functionality. There isn't much of this that we have a model for automatic testing for.


PR Comment: https://git.openjdk.org/skara/pull/1521#issuecomment-1546410866

More information about the skara-dev mailing list