RFR: 1912: Show priority for bugs in pull request body [v2]

Zhao Song zsong at openjdk.org
Tue May 23 22:43:30 UTC 2023

On Tue, 23 May 2023 18:15:40 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBot.java line 77:
>>> 75:     private final boolean enableBackport;
>>> 76:     private final Map<String, List<String>> issuePRMap;
>>> 77:     private final Map<String, Boolean> initializedPRs = new ConcurrentHashMap<>();
>> This could just be a `Set`. Also it doesn't need to be concurrent as it's local to just this PullRequestBot, and we don't run WorkItems for the same PR in parallel.
> Ah, right! Thanks!

Think again about this, It's possible that CheckWorkItems for different PRs in the same repo run in parallel. Every CheckWorkItem is possible to modify `initializedPRs`. So we still need synchronize it.


PR Review Comment: https://git.openjdk.org/skara/pull/1523#discussion_r1203110581

More information about the skara-dev mailing list