RFR: 1912: Show priority for bugs in pull request body [v2]
Zhao Song
zsong at openjdk.org
Tue May 23 23:03:24 UTC 2023
On Tue, 23 May 2023 22:58:36 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Think again about this, It's possible that CheckWorkItems for different PRs in the same repo run in parallel. Every CheckWorkItem is possible to modify `initializedPRs`. So we still need to synchronize it.
>
> You are right, the map will be concurrently modified, just not the same element, and that requires a `ConcurrentHashMap` or synchronization to avoid corrupting data. I think `ConcurrentHashMap` is preferred here as I don't think there is a concurrent Set.
Yes, I will change it back
-------------
PR Review Comment: https://git.openjdk.org/skara/pull/1523#discussion_r1203126861
More information about the skara-dev
mailing list