RFR: 2088: Skara /reviewers command is no longer effective

[Erik Joelsson]

On Thu, 2 Nov 2023 14:10:42 GMT, Erik Duveblad <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this fix for [SKARA-2088](https://bugs.openjdk.org/browse/SKARA-2088). The fix consists of adding a special value (`disable`) to the key `minimum` in the `[checks "reviewers"]` subsection. This way the functionality enabled by the `minimum` key can be disabled by `AdditionalConfiguration.java` (since INI doesn't feature a way for keys to be unset).
> 
> I also made the `ReviewersCheckConfiguration` a bit more strict - the `minimum` key should never be combined with the keys `lead`, `reviewers`, `committers`, `authors` or `contributors`.
> 
> Finally I added tests for the above three scenarios.
> 
> Thanks,
> Erik

Marked as reviewed by erikj (Lead).

jcheck/src/main/java/org/openjdk/skara/jcheck/ReviewersConfiguration.java line 137:

> 135:                 for (var role : List.of("lead", "reviewers", "committers", "authors", "contributors")) {
> 136:                     if (s.contains(role)) {
> 137:                         throw new IllegalStateException("Cannot combine 'minimum' with '" + role + "'");

Is there any risk that existing .jcheck/conf files will become invalid because of this new failure mode?

-------------

PR Review: https://git.openjdk.org/skara/pull/1581#pullrequestreview-1710542841
PR Review Comment: https://git.openjdk.org/skara/pull/1581#discussion_r1380298946