RFR: 2088: Skara /reviewers command is no longer effective [v2]

[Erik Duveblad]

On Thu, 2 Nov 2023 15:08:08 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Erik Duveblad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove import
>
> jcheck/src/main/java/org/openjdk/skara/jcheck/ReviewersConfiguration.java line 137:
> 
>> 135:                 for (var role : List.of("lead", "reviewers", "committers", "authors", "contributors")) {
>> 136:                     if (s.contains(role)) {
>> 137:                         throw new IllegalStateException("Cannot combine 'minimum' with '" + role + "'");
> 
> Is there any risk that existing .jcheck/conf files will become invalid because of this new failure mode?

Yes, but I have never seen a `.jcheck/conf` file with both `minimum` and e.g. `reviewers` set. I looked through all github.com/openjdk repositories and there are only three non-archived repos that has `minimum` set:
- [jmc](https://github.com/openjdk/jmc/blob/master/.jcheck/conf#L49)
- [jmc-graphics](https://github.com/openjdk/jmc-graphics/blob/master/.jcheck/conf#L48)
- [jfx11u](https://github.com/openjdk/jfx11u/blob/master/.jcheck/conf#L43)

None of the above has conflicting keys set, so with this patch we will be able to handle them all. So I think we are good here 👍

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1581#discussion_r1380759458